build: use also different K8s versions for E2E testing in GHA #659
Conversation
google-oss-prow
bot
requested review from
andreyvelich,
ckadner and
zijianjoy
Signed-off-by: Matteo Mortari <[email protected]>
tarilabs
force-pushed
the
tarilabs-20241216-matrixK8sVersionE2E
branch
from
3d0bda2 to
5cddf56
Compare
Signed-off-by: Matteo Mortari <[email protected]>
tarilabs
force-pushed
the
tarilabs-20241216-matrixK8sVersionE2E
branch
from
73873cd to
7bf5582
Compare
Signed-off-by: Matteo Mortari <[email protected]>
Revert "demo on PR how it would look on main merges" This reverts commit ecd8778. Signed-off-by: Matteo Mortari <[email protected]>
|
with ecd8778 demo-ing on PR how it would look like on main merges: with f41b2cd showing how it is effective on PR:
@Al-Pragliola @lampajr wdyt? |
| - kubernetes-version: ${{ github.event_name != 'push' && 'v1.28.7' }} | ||
| - kubernetes-version: ${{ github.event_name != 'push' && 'v1.29.2' }} | ||
| - kubernetes-version: ${{ github.event_name != 'push' && 'v1.30.6' }} |
There was a problem hiding this comment.
I did not know you could add such "boolean" conditions on the exclude, really interesting!
There was a problem hiding this comment.
It's a neat trick I discovered recently, but the "limitation" is that the order will always be 1. Exclusion, 2. Inclusion
So there is only so much can be done in 1 matrix
For more complex cases, the solution would be to produce the matrix in one job, and consume in another job--that's what also GHA docs advise in general
For this case, this was compact enough imho
|
nice work! /lgtm /approve |
Signed-off-by: Matteo Mortari <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Al-Pragliola, lampajr, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
proposal for #614
Description
please note
from: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#excluding-matrix-configurations
How Has This Been Tested?
see #659 (comment)
Merge criteria:
DCOcheck)If you have UI changes