-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] create bookmark #119 #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 3 New issues |
zbqmgldjfh
added a commit
that referenced
this pull request
Jan 23, 2024
* refactor(ErrorCode): 사용하지 않는 에러코드 제거 * feat(Bookmarks): User의 Bookmarks 구현 * feat(UserQueryRepositoryImpl#findAllBookmarks): User가 구독한 공지를 조회하는 조회 메서드 구현 * feat(DepartmentNoticeRepository): 사용하지 않는 DepartmentNoticeRepository 제거 * feat(NoticeService#getNoticeV1): 사용하지 않는 메서드 제거 * feat(FeedbackService): 사용하지 않는 feedback 서비스 제거 * refactor(AcceptanceTest): 공통된 FirebaseMockBean 상위계층으로 올리기 * test(UserAcceptanceTest): 사용자가 북마크를 저장하는 인수테스트 작성 * test(UserAcceptanceTest): 북마크 인수테스트 릭팩토링 * feat(UserCommandApiV2#saveBookmark): 공지 북마크 기능 구현 완료 * refactor(UserRepositoryTest): 사용자의 id로 북마크한 공지를 조회하는 메서드를 NoticeRepository로 이동한다 * feat: 북마크한 공지 조회 기능 구현 * refactor: test 페키지 리팩토링 * refactor: test의 서식 지정자 제거 * docs(README.md): 내용 일부 업데이트
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 사항