Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] create bookmark #119 #124

Merged
merged 15 commits into from
Jan 23, 2024
Merged

[Feat] create bookmark #119 #124

merged 15 commits into from
Jan 23, 2024

Conversation

zbqmgldjfh
Copy link
Member

구현 사항

  • 북마크 생성 기능
  • 북마크한 공지 조회 기능
  • 테스트 페키지 일부 수정
  • NoticeRepository와 DepartmentNoticeRepository 통합

@zbqmgldjfh zbqmgldjfh self-assigned this Jan 23, 2024
Copy link

github-actions bot commented Jan 23, 2024

Unit Test Results

  31 files  +3    31 suites  +3   22s ⏱️ +2s
132 tests +6  132 ✔️ +6  0 💤 ±0  0 ±0 
135 runs  +7  135 ✔️ +7  0 💤 ±0  0 ±0 

Results for commit c060c92. ± Comparison against base commit 18e60b9.

♻️ This comment has been updated with latest results.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
88.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@zbqmgldjfh zbqmgldjfh merged commit 3a2a597 into develop Jan 23, 2024
4 checks passed
@zbqmgldjfh zbqmgldjfh deleted the feat/create-bookmark-#119 branch January 23, 2024 07:09
zbqmgldjfh added a commit that referenced this pull request Jan 23, 2024
* refactor(ErrorCode): 사용하지 않는 에러코드 제거

* feat(Bookmarks): User의 Bookmarks 구현

* feat(UserQueryRepositoryImpl#findAllBookmarks): User가 구독한 공지를 조회하는 조회 메서드 구현

* feat(DepartmentNoticeRepository): 사용하지 않는 DepartmentNoticeRepository 제거

* feat(NoticeService#getNoticeV1): 사용하지 않는 메서드 제거

* feat(FeedbackService): 사용하지 않는 feedback 서비스 제거

* refactor(AcceptanceTest): 공통된 FirebaseMockBean 상위계층으로 올리기

* test(UserAcceptanceTest): 사용자가 북마크를 저장하는 인수테스트 작성

* test(UserAcceptanceTest): 북마크 인수테스트 릭팩토링

* feat(UserCommandApiV2#saveBookmark): 공지 북마크 기능 구현 완료

* refactor(UserRepositoryTest): 사용자의 id로 북마크한 공지를 조회하는 메서드를 NoticeRepository로 이동한다

* feat: 북마크한 공지 조회 기능 구현

* refactor: test 페키지 리팩토링

* refactor: test의 서식 지정자 제거

* docs(README.md): 내용 일부 업데이트
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant