Skip to content

Commit

Permalink
[Refactor] delete sentry (#117)
Browse files Browse the repository at this point in the history
* docs(readme): Batch Insert 부분 관련 정리글 링크 추가

* refactor: sentry에 대한 의존성 제거
  • Loading branch information
zbqmgldjfh authored Jan 17, 2024
1 parent a727be6 commit 0a4118d
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 13 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,8 @@ MySQL과 MariaDB의 Table Id 전략은 대부분이 IDENTITY 전략을 사용하
### 5-2) Delete 해결책
이미 프로젝트에서 queryDsl를 사용하고 있어 이를 이용하는 것이 가장 간단했기 때문에 queryDsl의 delete in 쿼리를 사용하여 해결했습니다.

**상세 내용 링크 : ([글 링크](https://blogshine.tistory.com/686))**

---

## 6. 인증, 인가를 비즈니스 로직으로부터 분리하기
Expand Down
4 changes: 0 additions & 4 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@ dependencies {
// flyway
implementation 'org.flywaydb:flyway-core'

// Logging
implementation 'io.sentry:sentry-spring-boot-starter:5.4.0'
implementation 'io.sentry:sentry-logback:5.4.0'

// DevTool
compileOnly 'org.projectlombok:lombok'
annotationProcessor 'org.projectlombok:lombok'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import com.kustacks.kuring.staff.domain.StaffRepository;
import com.kustacks.kuring.worker.scrap.StaffScraper;
import com.kustacks.kuring.worker.scrap.deptinfo.DeptInfo;
import io.sentry.Sentry;
import lombok.extern.slf4j.Slf4j;
import org.springframework.scheduling.annotation.Scheduled;
import org.springframework.stereotype.Component;
Expand Down Expand Up @@ -55,7 +54,6 @@ public void update() {
successDeptNames.add(deptInfo.getDeptName());
} catch (InternalLogicException e) {
log.error("[StaffScraperException] {}학과 교직원 스크래핑 문제 발생.", deptInfo.getDeptName());
Sentry.captureException(e);
}
}

Expand Down
4 changes: 0 additions & 4 deletions src/main/resources/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,6 @@ logging:
file:
name: classpath:/kuring.log

sentry:
traces-sample-rate: '1.0'
dsn: ${SENTRY_URL}

management:
endpoint:
health:
Expand Down
3 changes: 0 additions & 3 deletions src/test/resources/application-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ testcontainers:
reuse:
enable: true

sentry:
dsn: ""

logging:
level:
p6spy: debug
Expand Down

0 comments on commit 0a4118d

Please sign in to comment.