Adding support for rotated vertical punctuation and vertical cartouches #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and vertical metrics (advance 900). The vertical punctuation's tracking is just barely acceptable, but I don't know how to improve it further.
… are more efficient.
…s, which are more efficient." This reverts commit cff1cf4. Microsoft products have trouble with the more efficient format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds vertical metrics, rotated vertical punctuation from the East Asian set at U+3001 - U+301B, and vertical cartouches.
The vertical punctuation's tracking is just barely acceptable, but I don't know how to systematically improve it further.
The vertical cartouches are done by a multiple-substitution lookup to replace the cartouche-containing glyph with the base (vertical) glyph followed by vertical cartouche. It will be hard to maintain because I don't think substitutions of this type can be done with variables.
The vertical metrics are a flat advance 900 for all glyphs except vertical cartouche which has an advance of 0. This should be perfectly suitable for the monospace version, which is the only one that I think would appeal to people writing vertically. The rotated glyphs are added to the proportional version along with vertical metrics so vertical cartouche can have an advance of 0, but I have made no effort to produce proportional vertical metrics.