fix cached or default expression swallowing falsy value

korfuri · Nov 14, 2024 · 4730884 · 4730884
1 parent 2047d22
commit 4730884
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/django_prometheus/cache/backends/django_memcached_consul.py b/django_prometheus/cache/backends/django_memcached_consul.py
@@ -15,6 +15,7 @@ def get(self, key, default=None, version=None):
         cached = super().get(key, default=None, version=version)
         if cached is not None:
             django_cache_hits_total.labels(backend="django_memcached_consul").inc()
-        else:
-            django_cache_misses_total.labels(backend="django_memcached_consul").inc()
-        return cached or default
+            return cached
+
+        django_cache_misses_total.labels(backend="django_memcached_consul").inc()
+        return default
diff --git a/django_prometheus/cache/backends/filebased.py b/django_prometheus/cache/backends/filebased.py
@@ -15,6 +15,7 @@ def get(self, key, default=None, version=None):
         cached = super().get(key, default=None, version=version)
         if cached is not None:
             django_cache_hits_total.labels(backend="filebased").inc()
-        else:
-            django_cache_misses_total.labels(backend="filebased").inc()
-        return cached or default
+            return cached
+
+        django_cache_misses_total.labels(backend="filebased").inc()
+        return default
diff --git a/django_prometheus/cache/backends/locmem.py b/django_prometheus/cache/backends/locmem.py
@@ -15,6 +15,7 @@ def get(self, key, default=None, version=None):
         cached = super().get(key, default=None, version=version)
         if cached is not None:
             django_cache_hits_total.labels(backend="locmem").inc()
-        else:
-            django_cache_misses_total.labels(backend="locmem").inc()
-        return cached or default
+            return cached
+
+        django_cache_misses_total.labels(backend="locmem").inc()
+        return default