Dollar sign escape

[FrenkenFlores]

IPMI commands get executed in a separate shell where the combination "status" has its own behavior. In our case,
Popen starts a new shell, for example by running /bin/bash, and when the BMC password contains the combination
above it gets replaced to "bin/bash" (in this case the combination holds the last executed command as a string).
I have added a method to Session class that will escape the dollar sign. Such behavior is expected with other signs
(like combination "^_") but I didn't find it critical.

[coveralls]

coverage: 69.842% (+0.009%) from 69.833%
when pulling a4859d1 on FrenkenFlores:dollar_sign_escape
into f0df31e on kontron:master.

[hthiery]

could you please meld the commits into one for a better review. you should also add testcase(s) for issues/enhancements that are not yet covered by a testcase.

thanks

[FrenkenFlores]

I have checked the Codacy Static Code Analysis reports. It has conflict with using hard coded password and Popen function from the subprocess library. But I wanted to emulate the same behavior as Ipmitool class. Can we ignore the reports and merge it?

[hthiery]

I have checked the Codacy Static Code Analysis reports. It have conflict with using hard coded password and the Popen function from the subprocess library. But I wanted to emulate the same behavior as Ipmitool class. Can we ignore the reports and merge it?

we can configure codacy to ignore tests, e.g. https://docs.codacy.com/repositories-configure/codacy-configuration-file/#ignore-files

[FrenkenFlores]

I have checked the Codacy Static Code Analysis reports. It have conflict with using hard coded password and the Popen function from the subprocess library. But I wanted to emulate the same behavior as Ipmitool class. Can we ignore the reports and merge it?

we can configure codacy to ignore tests, e.g. https://docs.codacy.com/repositories-configure/codacy-configuration-file/#ignore-files

I can't configure codacy by myself, I will wait for you to skip it.

[FrenkenFlores]

@hthiery Hi!) Is there any update on this PR?

[hthiery]

@hthiery Hi!) Is there any update on this PR?

I just see that calling ipmitool with popen and Shell=True is an issue .

Using e.g.: ./ipmitool.py -vv -I ipmitool -o interface_type=lan -H 10.0.114.137 -U '";$(xterm);"' -P admin bmc info can execute something that is embedded in user or password.

So I think we should change Shell=True to Shell=False

[FrenkenFlores]

Ok. I will look into it)