Feature/cleanup interface #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heiko Thiery <[email protected]>
This empty methods now are called from Ipmi class. From Ipmi() class also the establish and close Session() methods are called. Signed-off-by: Heiko Thiery <[email protected]>
Add new args for __init__ and adopt create_connection() accordingly Signed-off-by: Heiko Thiery <[email protected]>
Add __enter__() and __exit__() methods to support context manager. Signed-off-by: Heiko Thiery <[email protected]>
Move device specific stuff to open() and close() methods. Signed-off-by: Heiko Thiery <[email protected]>
Signed-off-by: Heiko Thiery <[email protected]>
Signed-off-by: Heiko Thiery <[email protected]>
Signed-off-by: Heiko Thiery <[email protected]>
Use the open() and close() methods instead of session establish() and close(). Signed-off-by: Heiko Thiery <[email protected]>
Signed-off-by: Heiko Thiery <[email protected]>
We need always a session. So we create if it is not passed on __init__. Also a session needs an interface, set it! Signed-off-by: Heiko Thiery <[email protected]>
Signed-off-by: Heiko Thiery <[email protected]>
Signed-off-by: Heiko Thiery <[email protected]>
Signed-off-by: Heiko Thiery <[email protected]>
hthiery
force-pushed
the
feature/cleanup-interface
branch
from
3c76fc8 to
cf7b27f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.