Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(RELEASE-1041): move and rename iib pipeline #756

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

refactor(RELEASE-1041): move and rename iib pipeline #756

wants to merge 2 commits into from
+1,076 −0

Conversation

theflockers
Copy link
Contributor

Signed-off-by: Leandro Mendes [email protected]

Describe your changes

Relevant Jira

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I have bumped the task/pipeline version string and updated changelog in the relevant README
  • I read CONTRIBUTING.MD and commit formatting

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@theflockers theflockers changed the title update-fbc-catalog chore(RELEASE-1041): move and rename iib pipeline Dec 18, 2024
@theflockers theflockers changed the title chore(RELEASE-1041): move and rename iib pipeline refactor(RELEASE-1041): move and rename iib pipeline Dec 18, 2024
@theflockers theflockers force-pushed the move-and-rename-ibb branch 7 times, most recently from 237a799 to 5f16c1e Compare December 20, 2024 15:47
@theflockers theflockers force-pushed the move-and-rename-ibb branch 7 times, most recently from f042ee4 to f67ce51 Compare January 10, 2025 11:27
@theflockers theflockers force-pushed the move-and-rename-ibb branch 10 times, most recently from 0dd033c to fddeaf6 Compare January 14, 2025 14:04
@theflockers theflockers marked this pull request as ready for review January 14, 2025 18:55
johnbieren
johnbieren reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the test descriptions?

tasks/internal/update-fbc-catalog-task/tests/test-update-fbc-catalog-default.yaml Outdated Show resolved Hide resolved
tasks/internal/update-fbc-catalog-task/tests/test-update-fbc-catalog-default.yaml Outdated Show resolved Hide resolved
tasks/internal/update-fbc-catalog-task/tests/test-update-fbc-catalog-timeout.yaml Outdated Show resolved Hide resolved
johnbieren
johnbieren reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test case for when check_previous_build returns something?

@theflockers
Copy link
Contributor Author

Is it possible to add a test case for when check_previous_build returns something?

Awesome catch. Found a bug after adding the test: https://github.com/hacbs-release/app-interface-deployments/pull/272/files

@johnbieren
Copy link
Collaborator

Is it possible to add a test case for when check_previous_build returns something?

Awesome catch. Found a bug after adding the test: https://github.com/hacbs-release/app-interface-deployments/pull/272/files

Great! I think it may be easiest to keep it out of this PR, we merge this, then open a followup PR with the bug fix and the test (since I assume the test won't pass without the fix)

@theflockers
Copy link
Contributor Author

Is it possible to add a test case for when check_previous_build returns something?

Awesome catch. Found a bug after adding the test: https://github.com/hacbs-release/app-interface-deployments/pull/272/files

Great! I think it may be easiest to keep it out of this PR, we merge this, then open a followup PR with the bug fix and the test (since I assume the test won't pass without the fix)

Ack!

@theflockers
Copy link
Contributor Author

Is it possible to add a test case for when check_previous_build returns something?

Awesome catch. Found a bug after adding the test: https://github.com/hacbs-release/app-interface-deployments/pull/272/files

Great! I think it may be easiest to keep it out of this PR, we merge this, then open a followup PR with the bug fix and the test (since I assume the test won't pass without the fix)

@johnbieren just one thing - the tests for the check_previous_build requires the fix to be there, so I will include the tests with the fix in the following up PR.

johnbieren
johnbieren previously approved these changes Jan 15, 2025
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2025
@openshift-ci openshift-ci bot removed the lgtm label Jan 16, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 16, 2025

New changes are detected. LGTM label has been removed.

@theflockers
refactor(RELEASE-1041): move and rename iib pipeline
99b4306 
this PR moves the IIB internal pipeline and tasks
to the release-service-catalog and renames it to
update-fbc-catalog.

also adds a workspace to save files that are
used by the task and tests.

Signed-off-by: Leandro Mendes <[email protected]>
@theflockers
Copy link
Contributor Author

/retest

@theflockers
Copy link
Contributor Author

@johnbieren I had previously changed the "add-fbc-contribution" to use the new pipeline, but turns out it breaks e2e and this should be only be done when the pipeline is onboarded to cluster. Can you take a look in the last change, please?

johnbieren
johnbieren reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, one comment. I guess you will have to update the add-fbc-contribution task in a new PR after this one merges

tasks/managed/add-fbc-contribution/README.md
@@ -13,6 +13,9 @@ Task to create a internalrequest to add fbc contributions to index images
| targetIndex | targetIndex value updated by update-ocp-tag task | No | - |
| resultsDirPath | Path to results directory in the data workspace | No | - |

## Changes in 3.4.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be dropped

@konflux-ci-qe-bot
Copy link

@theflockers: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-tests-catalog-mxf7k Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-mxf7k

Test results analysis

<not enabled>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbieren johnbieren johnbieren left review comments

@mmalina mmalina mmalina left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@johnbieren johnbieren

Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theflockers @johnbieren @konflux-ci-qe-bot @mmalina