fix(Konflux 5917): add an example how user can use a secret in pipeline #208
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 14, 2025 20:52
Signed-off-by: Kasem Alem <[email protected]>
This reverts commit adbb34e.
Signed-off-by: Kasem Alem <[email protected]>
kasemAlem
changed the title
|
🚀 Preview is available at https://pr-208--konflux-docs.netlify.app |
Josh-Everett
approved these changes
Jan 15, 2025
arewm
reviewed
Jan 16, 2025
Comment on lines
+68
to
+70
| - name: registry-credentials | ||
| secret: | ||
| secretName: registry.redhat.io |
There was a problem hiding this comment.
This is how you use a secret, but what does this secret look like that you are using? Is it clear how values need to match up between the secret and its use?
There was a problem hiding this comment.
+1. I think only one secret name in volumes might not enough as one example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a tekton task as an example how user can use the created secrets
within a build or integration pipeline
KONFLUX-5917