Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the name of the snyk secret to create #206

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

arewm
Copy link
Member

@arewm arewm commented Jan 14, 2025

The default secret name for the task is snyk-secret: https://github.com/konflux-ci/build-definitions/blob/9f209df8c12e8b321e63b77b5c91cb1523080a59/task/sast-snyk-check-oci-ta/0.3/sast-snyk-check-oci-ta.yaml#L49-L51

Therefore, in order to make it work out of the box, that should probably be the name that we suggest for users to configure.

The default secret name for the task is `snyk-secret`: https://github.com/konflux-ci/build-definitions/blob/9f209df8c12e8b321e63b77b5c91cb1523080a59/task/sast-snyk-check-oci-ta/0.3/sast-snyk-check-oci-ta.yaml#L49-L51

Therefore, in order to make it work out of the box, that should probably
be the name that we suggest for users to configure.

Signed-off-by: arewm <[email protected]>
@arewm arewm requested a review from dirgim January 14, 2025 20:48
Copy link

🚀 Preview is available at https://pr-206--konflux-docs.netlify.app

Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dirgim dirgim merged commit a896bd7 into konflux-ci:main Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants