Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable EC Task checks #761

Merged
merged 1 commit into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .tekton/pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -201,15 +201,14 @@ spec:
workspaces:
- name: source
workspace: workspace
# This will be re-enabled as part of https://issues.redhat.com/browse/EC-332
# - name: ec-task-checks
# runAfter:
# - fetch-repository
# taskRef:
# name: ec-checks
# workspaces:
# - name: source
# workspace: workspace
- name: ec-task-checks
runAfter:
- fetch-repository
taskRef:
name: ec-checks
workspaces:
- name: source
workspace: workspace
- name: check-task-migration-md
runAfter:
- fetch-repository
Expand Down
8 changes: 8 additions & 0 deletions .tekton/push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ spec:
workspaces:
- name: output
workspace: workspace
- name: ec-task-checks
runAfter:
- clone-repository
taskRef:
name: ec-checks
workspaces:
- name: source
workspace: workspace
- name: build-container
params:
- name: IMAGE
Expand Down
48 changes: 22 additions & 26 deletions .tekton/tasks/ec-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,34 +25,30 @@ spec:
- name: validate-all-tasks
workingDir: "$(workspaces.source.path)/source"
image: quay.io/enterprise-contract/ec-cli:snapshot
command: [ec]
args:
- validate
- definition
- "--file"
- "./all_tasks-ec"
- "--policy"
- "git::https://github.com/enterprise-contract/ec-policies//policy/task"
- "--policy"
- "git::https://github.com/enterprise-contract/ec-policies//policy/lib"
- "--data"
- "git::https://github.com/release-engineering/rhtap-ec-policy//data"
- "--strict"
script: |
set -euo pipefail

# Generate list of file parameters, e.g. --file foo.yaml --file bar.yaml
files=(all_tasks-ec/*.yaml)
args=${files[*]/#/--file }
echo "[DEBUG] Files parameter: ${args[*]}"

policy='enterprise-contract-service/redhat-trusted-tasks'

ec validate input --policy "${policy}" --output yaml --strict=true ${args[*]}
- name: validate-build-tasks
workingDir: "$(workspaces.source.path)/source"
image: quay.io/enterprise-contract/ec-cli:snapshot
command: [ec]
args:
- validate
- definition
- "--file"
- "./build_tasks-ec"
- "--policy"
- "git::https://github.com/enterprise-contract/ec-policies//policy/build_task"
- "--policy"
- "git::https://github.com/enterprise-contract/ec-policies//policy/lib"
- "--data"
- "git::https://github.com/release-engineering/rhtap-ec-policy//data"
- "--strict"
script: |
set -euo pipefail

# Generate list of file parameters, e.g. --file foo.yaml --file bar.yaml
files=(build_tasks-ec/*.yaml)
args=${files[*]/#/--file }
echo "[DEBUG] Files parameter: ${args[*]}"

policy='./policies/build-tasks.yaml'

ec validate input --policy "${policy}" --output yaml --strict=true ${args[*]}
workspaces:
- name: source
9 changes: 9 additions & 0 deletions policies/build-tasks.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
# These policies are meant to be applied to the build Tasks in this repo. These are policy rules
# that are very specific to the use cases in this repo. Thus, they are defined here instead of in a
# more generic location, e.g. infra-deployments repository.
sources:
- policy:
- quay.io/enterprise-contract/ec-build_task-policy:latest
data:
- git::https://github.com/release-engineering/rhtap-ec-policy//data