Bit more verbose output from the switchboard task #1677
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeliik
reviewed
Dec 2, 2024
zregvart
force-pushed
the
pr/verbose-switchboard
branch
from
c974eed to
f2d171b
Compare
zregvart
force-pushed
the
pr/verbose-switchboard
branch
from
f2d171b to
27d1120
Compare
chmeliik
reviewed
Dec 20, 2024
It's an edge case when the same commit exists in two or more pull requests, for unmerged pull requests this can be when one pull request is based on another pull request. I had this issue in the pipeline triggered on push, probably not as frequent for unmerged pull requests. |
chmeliik
approved these changes
Dec 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Hmm, the error from the task-switchboard is: |
Makes it easier to debug eventual issues and makes it easier to fine tune expressions.
Due to rebasing the same revision that triggered the pipeline for one pull request can occur in other pull requests. With this not only the first result from `gh search prs` is used, changes from all of them are considered. This means that some Tasks that might not need to run are still ran, this should be acceptable given it guarantees that all Tasks that need to run have ran.
zregvart
force-pushed
the
pr/verbose-switchboard
branch
from
27d1120 to
728b6f9
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to debug eventual issues and makes it easier to fine tune expressions.
Also a fix in c974eed to search only merged pull requests. I could have done a separate pull request, but then I'd need to rebase this so this was easier