-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parental rating fields to EPG, Timers and Recordings. #137
Add parental rating fields to EPG, Timers and Recordings. #137
Conversation
@phunkyfish - I received an email notification that this build had failed after you appear to have manually re-triggered it: "Build and run tests, Attempt #2: All jobs have failed" I've also seen this message on GitHub: "This request was automatically failed because there were no enabled runners online to process the request for more than 1 days." This seems to me to be an issue with the build system. However, can you please let me know if this was caused by something that I missed when submitting my PR? |
Two comments:
|
a9a2620
to
b5b2d2e
Compare
Updated as requested. |
b5b2d2e
to
c9cd0f4
Compare
The previous force-push was an update to accommodate xbmc/xbmc#24096 (adding parental rating icons). |
As I said in the pvr.hts PR, merge of this must wait until P* dev cycle has started, because of the Addon-API change which will not be part of Omega. |
pvr.demo/addon.xml.in
Outdated
@@ -1,7 +1,7 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<addon | |||
id="pvr.demo" | |||
version="21.0.0" | |||
version="21.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will definitely end up with some 22.x.y number
c9cd0f4
to
1e6b5c7
Compare
1e6b5c7
to
b55d5f5
Compare
We cannot merge this for Omega, due to API incompatibility. |
v22.0.0
Add parental rating fields in support of Kodi PR #24096
Access via $INFO[ListItem.ParentalRating], $INFO[ListItem.ParentalRatingCode], $INFO[ListItem.ParentalRatingIcon] and $INFO[ListItem.ParentalRatingSource] respectively.
Add ability to populate existing cast, director and writer fields. Access via existing info labels.
Note: 'ListItem.ParentalRatingCode' will be available once Kodi PR 23586 has been merged. However, the columns are already in the epgtags table of the PVR/EPG database.