Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parental rating fields to EPG, Timers and Recordings. #137

Closed

Conversation

DeltaMikeCharlie
Copy link
Contributor

@DeltaMikeCharlie DeltaMikeCharlie commented Sep 19, 2023

v22.0.0

Add parental rating fields in support of Kodi PR #24096

Access via $INFO[ListItem.ParentalRating], $INFO[ListItem.ParentalRatingCode], $INFO[ListItem.ParentalRatingIcon] and $INFO[ListItem.ParentalRatingSource] respectively.

Add ability to populate existing cast, director and writer fields. Access via existing info labels.

Note: 'ListItem.ParentalRatingCode' will be available once Kodi PR 23586 has been merged. However, the columns are already in the epgtags table of the PVR/EPG database.

@DeltaMikeCharlie
Copy link
Contributor Author

@phunkyfish - I received an email notification that this build had failed after you appear to have manually re-triggered it: "Build and run tests, Attempt #2: All jobs have failed"

I've also seen this message on GitHub: "This request was automatically failed because there were no enabled runners online to process the request for more than 1 days."

This seems to me to be an issue with the build system. However, can you please let me know if this was caused by something that I missed when submitting my PR?

@ksooo
Copy link
Member

ksooo commented Sep 21, 2023

Two comments:

  • as you are adding a new feature with this release, please increase addon minor version number, not micro
  • I would use different combinations for the entries, some with both new values, some with only one, some without. Pvr.demo is more for demonstration of features and testing. That way for example we can easily see how different combinations are presented in Estuary.

src/PVRDemo.h Outdated Show resolved Hide resolved
@DeltaMikeCharlie
Copy link
Contributor Author

Two comments:

* as you are adding a new feature with this release, please increase addon minor version number, not micro

* I would use different combinations for the entries, some with both new values, some with only one, some without. Pvr.demo is more for demonstration of features and testing. That way for example we can easily see how different combinations are presented in Estuary.

Updated as requested.

@DeltaMikeCharlie
Copy link
Contributor Author

The previous force-push was an update to accommodate xbmc/xbmc#24096 (adding parental rating icons).

@ksooo
Copy link
Member

ksooo commented Nov 13, 2023

As I said in the pvr.hts PR, merge of this must wait until P* dev cycle has started, because of the Addon-API change which will not be part of Omega.

@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<addon
id="pvr.demo"
version="21.0.0"
version="21.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will definitely end up with some 22.x.y number

@ksooo ksooo added the PVR API change Related to coming change on Kodi (not merge here before!) label Nov 13, 2023
@DeltaMikeCharlie DeltaMikeCharlie changed the title Add parentalRatings to EPG. Add parental rating fields to EPG, Timers and Recordings. Jun 18, 2024
@ksooo
Copy link
Member

ksooo commented Aug 19, 2024

We cannot merge this for Omega, due to API incompatibility.

@ksooo ksooo closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PVR API change Related to coming change on Kodi (not merge here before!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants