Fix the initial HorizontalScroll position change

kiwicom · Aug 9, 2024 · bd2e232 · bd2e232
1 parent 7da1b42
commit bd2e232
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/Sources/Orbit/Support/Layout/HorizontalScrollPosition.swift b/Sources/Orbit/Support/Layout/HorizontalScrollPosition.swift
@@ -11,16 +11,18 @@ struct HorizontalScrollPositionModifier: ViewModifier {
     func body(content: Content) -> some View {
         HorizontalScrollReader { proxy in
             content
-                .onChange(of: position) {
+                .onChange(of: position) { newValue in
                     if isModified {
                         isModified = false
                         return
                     }
-                    proxy.scrollTo($0, animated: animated)
+                    proxy.scrollTo(newValue, animated: animated)
                 }
-                .onPreferenceChange(HorizontalScrollScrolledItemIDKey.self) {
-                    isModified = true
-                    position = $0
+                .onPreferenceChange(HorizontalScrollScrolledItemIDKey.self) { value in
+                    if position != value {
+                        isModified = true
+                        position = value
+                    }
                 }
         }
     }