Update plexus-archiver and poi dependency #6362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stweil
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #6174 i encountered the problem that the currently installed versions of plexus-archiver and apache-poi require different versions of Apache commons-compress. (https://commons.apache.org/proper/commons-compress/)
Via plexus-archiver a older version (1.23.0) of commons-compress is installed as transitive dependency which seems to be incompatible with the installed version of apache poi. The incompatibility only manifests itself when generating modern generation Excel files, which seem to rely on commons-compress.
In addition to that there are vulnerabilities for the installed version (1.23.0) of commons-compress (https://mvnrepository.com/artifact/org.apache.commons/commons-compress)
To adress both the incompatbility as well as the security issues, this PR updates apache-poi and plexus-archiver to their latest version. This brings commons-compress to version 1.26.2. I have not yet discovered any issues by doing so. PDF and Excel file generation are still working.