Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4838 add development profile to kitodo which puts the jsf project st… #4889

Conversation

markusweigelt
Copy link
Collaborator

@markusweigelt markusweigelt commented Dec 16, 2021

…age on development

When maven profile development is used the JSF PROJECT_STAGE the project stage is set to "Development".

Maven WAR Plugin is updated too btw.

Fixes #4838

Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are okay.

Change of FACELETS_BUFFER_SIZE to 5 MB should be okay too but must be maybe changed if this value is to big. Default value is 1024.

@solth
Copy link
Member

solth commented Jan 11, 2022

Very nice for developers! Works like a charm! 👍

Copy link
Collaborator

@matthias-ronge matthias-ronge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to abstain here. I don’t know how Eclipse internally handles the debug mode. So I cannot say, if I test this, if the changes have any effect under Eclipse. I’m sorry.

@markusweigelt
Copy link
Collaborator Author

markusweigelt commented Jan 17, 2022

@matthias-ronge Behaviour of this improvement is independent from your IDE or debug mode of IDE. Maven uses the "Development" Profile by default. For example when you run "mvn clean install" then the web.xml is adjusted during generation and the project stage is set to "Development". This causes the error messages from Java Server Faces to be displayed.

@Kathrin-Huber Kathrin-Huber merged commit 154ed9a into kitodo:master Jan 18, 2022
@markusweigelt markusweigelt deleted the add_development_profile_to_kitodo_module branch November 7, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ViewExpiredException when rendering error.xhtml
5 participants