Pass and verify a JWT token in the state parameter #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tschonti
requested review from
FearsomeRover,
berenteb,
tomitheninja and
triszt4n
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should defend against CSRF attacks, but honestly, I don't understand them fully, so I'm not 100% sure this prevents anything. I'm also not 100% sure that it won't cause problems for some users. so this needs review and testing with more real users.
This had to be a major update because the new JWT needs a secret, and I didn't want to use the AuthSCH secret. Also removed a few types that are only used internally (hopefully) from the exports.
https://www.rfc-editor.org/rfc/rfc6749#section-10.12