Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove preinstall #910

Merged
merged 3 commits into from
Oct 24, 2024
Merged

fix: remove preinstall #910

merged 3 commits into from
Oct 24, 2024
+64 −1

Conversation

tasshi-me
Copy link
Member

@tasshi-me tasshi-me commented Oct 23, 2024 •
edited
Loading

Why

cli-kintone v1.12.0 uses only-allow package in preinstall npm-scripts.

It causes installation failure in some situations.

https://github.com/kintone/cli-kintone/actions/runs/11484169162

In this PR, we delete the preinstall script of this package.

What

  • remove preinstall npm-scripts
  • add tests for npm install and npx

How to test

See test-npm CI result.

https://github.com/kintone/cli-kintone/actions/runs/11484055117?pr=910

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added/updated tests if it is required. (or tested manually)
  • Passed pnpm lint and pnpm test on the root directory.

@tasshi-me tasshi-me self-assigned this Oct 23, 2024
@tasshi-me tasshi-me mentioned this pull request Oct 23, 2024
Closed
4 tasks
@tasshi-me tasshi-me marked this pull request as ready for review October 24, 2024 00:43
@tasshi-me tasshi-me requested a review from a team as a code owner October 24, 2024 00:43
@tasshi-me tasshi-me requested review from chihiro-adachi and shabaraba and removed request for a team October 24, 2024 00:43
chihiro-adachi
chihiro-adachi approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@chihiro-adachi chihiro-adachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ないです。ご対応ありがとうございます！

@tasshi-me tasshi-me merged commit 28318f2 into main Oct 24, 2024
32 checks passed
@tasshi-me tasshi-me deleted the fix/remove-preinstall branch October 24, 2024 01:32
This was referenced Oct 24, 2024
Merged
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Nov 6, 2024
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Dec 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chihiro-adachi chihiro-adachi chihiro-adachi approved these changes

@shabaraba shabaraba Awaiting requested review from shabaraba shabaraba is a code owner automatically assigned from kintone/extensions-platform

Assignees

@tasshi-me tasshi-me

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tasshi-me @chihiro-adachi