Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: centralize implementation of common options #896

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

tasshi-me
Copy link
Member

@tasshi-me tasshi-me commented Oct 22, 2024

Why

cli-kintone has common options for all commands (authn, logging, proxy, etc.)

Curerently, they are implemented on each command separately.

It can lead to wrong updates on common options.

What

  • centralize implementation of common options

How to test

pnpm install
pnpm build
pnpm test

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added/updated tests if it is required. (or tested manually)
  • Passed pnpm lint and pnpm test on the root directory.

@tasshi-me tasshi-me self-assigned this Oct 22, 2024
@tasshi-me tasshi-me marked this pull request as ready for review October 22, 2024 13:01
Copy link
Contributor

@chihiro-adachi chihiro-adachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題なさそうです!

@tasshi-me tasshi-me requested a review from a team as a code owner October 23, 2024 05:16
@tasshi-me tasshi-me merged commit 6c53c50 into main Oct 23, 2024
9 of 10 checks passed
@tasshi-me tasshi-me deleted the refactor/merge-implementation-of-common-options branch October 23, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants