Add the possiblity to do a major release #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazzitelli
reviewed
Oct 18, 2024
| NEXT_VERSION=$(python bump.py $RELEASE_TYPE $RELEASE_VERSION) | ||
| elif [[ $RELEASE_TYPE == "major" ]] | ||
| then | ||
| NEXT_VERSION=$(python bump.py "minor" $RELEASE_VERSION) |
There was a problem hiding this comment.
I have no idea if this is right or wrong, but this just caught my eye. Since release type is "major" here, shouldn't the bump.py be sent in "major" as its argument value?
Suggested change
| NEXT_VERSION=$(python bump.py "minor" $RELEASE_VERSION) | |
| NEXT_VERSION=$(python bump.py "major" $RELEASE_VERSION) |
There was a problem hiding this comment.
For that case, which is calculate the next version, the bump shouldn't be to 3.0, but to 2.1 instead, for that reason I'm setting a minor bump there.
jmazzitelli
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to do major releases.
Schedule runs are disabled for now.
This PR also sets the 2.0 version for the next Kiali major release on next Monday.