Refactor graphical tests with vdiffr::expect_doppelganger()
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175
This PR refactors all graphical snapshot tests to use
vdiffr::expect_doppelganger()which saves and compares to reproducible SVG outputs, and add the snapshot SVG files to the repo.Note that
.Rbuildignorestill hastests/testthat/_snaps/ignored. This means the snapshot won't be available for comparison when runningR CMD checkand the snapshot tests will always pass. Making the snapshots available and tracked in the repo is still useful though because they can be compared to in development mode, such as when runningdevtools::test().