Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate K8up Helm chart #705

Merged
merged 7 commits into from
Jul 15, 2022
Merged

Integrate K8up Helm chart #705

merged 7 commits into from
Jul 15, 2022

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Jul 13, 2022

Summary

Part 1 of #649:

  • Integrates the K8up chart over from APPUiO repo (https://github.com/appuio/charts/tree/master/appuio/k8up)
  • Adjustments to GH actions to support 2 kinds of different releases:
    • When releasing K8up as operator, existing tagging scheme applies, e.g. v2.3.5
    • When releasing K8up chart, git tags need to be in the format: k8up-3.0.1 (k8up as prefix, no v prefix in the version number)
    • Currently, there's no support for releasing charts as Prereleases (-rc#) yet, maybe later.
    • Release automation also attaches the K8up CRDs as a downloadable yaml, to make helm installation easier (see [k8up] Attach CRDs to GitHub release appuio/charts#419)
  • Chart is bumped to v3.0.0 simply due to the move, to communicate a clear cut where the new charts are
  • Charts from 2.x will not be moved and stay in the APPUiO repo for now
  • Adds new labels for GitHub PRs: area:operator, area:chart, chart:k8up to help build the release notes when releasing either code or chart.
  • Release process page updated in docs

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update the documentation.
  • Update tests.
  • Link this PR to related issues.

@ccremer ccremer added the change Generic change that is neither a fix or feature label Jul 13, 2022
@ccremer ccremer requested a review from a team as a code owner July 13, 2022 13:50
@ccremer ccremer requested review from bastjan and Kidswiss and removed request for a team July 13, 2022 13:50
@ccremer ccremer marked this pull request as draft July 13, 2022 13:51
@ccremer ccremer removed request for bastjan and Kidswiss July 13, 2022 13:51
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccremer ccremer marked this pull request as ready for review July 14, 2022 07:10
ccremer added 7 commits July 14, 2022 11:15
Signed-off-by: ccremer <[email protected]>
This change avoids the constant pinning of versions
in the chart, with a follow-up chart release in case it changes.

Signed-off-by: ccremer <[email protected]>
@ccremer ccremer merged commit 45a068b into master Jul 15, 2022
@ccremer ccremer deleted the helm-repo branch July 15, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:operator change Generic change that is neither a fix or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants