-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(main): SecretSyncController split namespaces #1400
Conversation
Initially opened this PR that caused the above 2 tests to fail:
I'm looking for advice on how to proceed from here. Any guidance on how to debug or pinpoint the root cause would be appreciated. |
They were just flakes, I reran the tests. |
Any chance you could create CHANGELOG entry? |
Sure |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create a follow up ticket for proper warmup for cluster-scoped deployments.
@burmanm Any chance you can rerun the failed checks please? |
Thanks for the PR. |
What this PR does:
Splits WatchNamespaces when multiple namespaces provided (WATCH_NAMESPACE)
Which issue(s) this PR fixes:
Fixes #1399
Checklist