Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary requeues #1153

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Remove unnecessary requeues #1153

merged 3 commits into from
Jan 5, 2024

Conversation

adejanovski
Copy link
Contributor

@adejanovski adejanovski commented Jan 4, 2024

What this PR does:
Removes the redundant requeue delay in case of reconcile error in the Medusa controllers.

Which issue(s) this PR fixes:
Fixes #1050

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (b39cc4d) 56.83% compared to head (dcad3ad) 56.95%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
+ Coverage   56.83%   56.95%   +0.11%     
==========================================
  Files         100      100              
  Lines       10352    10352              
==========================================
+ Hits         5884     5896      +12     
+ Misses       3950     3942       -8     
+ Partials      518      514       -4     
Files Coverage Δ
controllers/medusa/medusatask_controller.go 46.07% <0.00%> (ø)
controllers/medusa/medusarestorejob_controller.go 57.33% <0.00%> (ø)
controllers/medusa/medusabackupjob_controller.go 56.52% <0.00%> (ø)

... and 4 files with indirect coverage changes

@adejanovski adejanovski marked this pull request as ready for review January 4, 2024 14:52
@adejanovski adejanovski requested a review from a team as a code owner January 4, 2024 14:52
@adejanovski adejanovski force-pushed the remove-requeue-medusa-errors branch from dcad3ad to 4231109 Compare January 5, 2024 15:18
@adejanovski adejanovski merged commit 6e668b1 into main Jan 5, 2024
9 checks passed
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the requeue delay when a Medusa reconcile errors out
2 participants