Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation check for projected pod names length #1120

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

adejanovski
Copy link
Contributor

What this PR does:
Checks if the projected pod names (for each dc and rack) could overflow the 63 characters limit. Fails the validation if it's the case.

Which issue(s) this PR fixes:
Fixes #1115

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@adejanovski adejanovski requested a review from a team as a code owner November 24, 2023 12:46
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (b39cc4d) 56.83% compared to head (7467eda) 57.02%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
+ Coverage   56.83%   57.02%   +0.18%     
==========================================
  Files         100      100              
  Lines       10352    10370      +18     
==========================================
+ Hits         5884     5913      +29     
+ Misses       3950     3939      -11     
  Partials      518      518              
Files Coverage Δ
...pis/k8ssandra/v1alpha1/k8ssandracluster_webhook.go 69.66% <55.55%> (-3.58%) ⬇️

... and 5 files with indirect coverage changes

@Miles-Garnsey
Copy link
Member

Issue: Have we seen this become an issue in practice? I've been reading this article and it indicates that for deployments, truncation of overlength names happens automatically.

But based on this comment I'm not sure if the same applies to statefulsets (particularly because they appear to have other issues with labels), and indeed it may be the case that an STS name over 52 characters will cause issues.

Just trying to figure out what we're doing here.

@adejanovski adejanovski force-pushed the add-object-name-length-validation branch from bc7629d to 7467eda Compare January 5, 2024 12:04
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adejanovski adejanovski merged commit a86edfe into main Jan 5, 2024
56 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a validation check for the projected pod names length
3 participants