Warn instead of raising exceptions in inf-check #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csukuangfj
reviewed
Dec 30, 2024
icefall/hooks.py
Outdated
| @@ -40,8 +40,8 @@ def register_inf_check_hooks(model: nn.Module) -> None: | |||
| def forward_hook(_module, _input, _output, _name=name): | |||
| if isinstance(_output, Tensor): | |||
| if not torch.isfinite(_output.to(torch.float32).sum()): | |||
| raise ValueError( | |||
| f"The sum of {_name}.output is not finite: {_output}" | |||
| logging.warning( | |||
There was a problem hiding this comment.
Will the training continue with inf loss and inf grad?
There was a problem hiding this comment.
Yes, like the backward code, it will just warn instead of printing the tensor and raising an exception.
There was a problem hiding this comment.
In that case, will it propagate the inf grad to model parameters and result in inf parameters?
There was a problem hiding this comment.
It is only applied with the inf-check option tuned on, i.e., for finding where the infinites are coming from. So it wouldn't affect normal model training.
|
Could you fix the style issues? |
yfyeung
pushed a commit
to yfyeung/icefall
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.