Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify thanks for new API in CSDP #48

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Simplify thanks for new API in CSDP #48

merged 4 commits into from
Oct 23, 2019

Conversation

blegat
Copy link
Member

@blegat blegat commented Oct 21, 2019

Simplification of the MOI wrapper thanks to coin-or/Csdp#12.
We play it safe now by considering most of CSDP internal data as a black box pointer so this PR should fix #39 and #40

@coveralls
Copy link

coveralls commented Oct 21, 2019

Coverage Status

Coverage decreased (-18.2%) to 46.837% when pulling 8f63bbf on bl/refactor into e367784 on master.

@codecov-io
Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #48 into master will decrease coverage by 15.8%.
The diff coverage is 73.13%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #48       +/-   ##
===========================================
- Coverage   70.55%   54.75%   -15.81%     
===========================================
  Files          10       10               
  Lines         557      652       +95     
===========================================
- Hits          393      357       -36     
- Misses        164      295      +131
Impacted Files Coverage Δ
src/CSDP.jl 100% <ø> (ø) ⬆️
src/blockmat.h.jl 72.72% <ø> (ø) ⬆️
src/blockmat.jl 60.62% <100%> (-22.05%) ⬇️
src/declarations.h.jl 19.84% <58.62%> (-24.82%) ⬇️
src/declarations.jl 38.88% <59.25%> (-58.99%) ⬇️
src/MPB_wrapper.jl 66.17% <75.75%> (+4.47%) ⬆️
src/MOI_wrapper.jl 76.96% <87.8%> (-0.01%) ⬇️
src/options.jl 44.44% <0%> (-55.56%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e367784...8f63bbf. Read the comment docs.

@blegat blegat merged commit 5038213 into master Oct 23, 2019
@blegat blegat mentioned this pull request Oct 23, 2019
@blegat blegat mentioned this pull request May 2, 2020
@odow odow deleted the bl/refactor branch October 26, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Sporadic malloc errors with CSDP 4.1
3 participants