Fix runtime modified graphics settings potentially being saved

[LostLuma]

Resolves #213 by reverting any modified settings while the Options.save method is being ran.

This sadly causes an additional world reload if using the minimal graphics state, however since this bug is exceedingly rare and users are already discouraged from using the minimal setting it I think this solution is acceptable.

Other ways of fixing the issue I've considered are way more work to write, maintain, and port to other Minecraft versions.

[juliand665]

Do you reckon it might be feasible and/or better to avoid the reload by redirecting whatever method gets the current options to save them to instead receive unmodified options? Oof that's quite the sentence—let me know if it makes sense

[LostLuma]

It is certainly possible and might be considered better, but I don't think it's really worth it.

redirecting whatever method gets the current options to save them to instead receive unmodified options

The issue with this is that the option enums / values aren't just stored as fields in the Options class, but wrapped inside an OptionInstance object, which is pretty difficult to reconstruct as it has only private fields and modifies the arguments passed to the constructor.

[LostLuma]

It might also be good to keep in mind that the game doesn't save your options randomly, but only if some sort of options screen is excited, or a setting is persisted (joining a multiplayer server, or finishing a tutorial step, ..) which should only happen during active gameplay or while the world hasn't rendered yet anyway.

[juliand665]

Good points. My last idea would be to inspect the stack trace (lol) to see if we're being persisted, and return unmodified values from our overrides if so

[LostLuma]

That has the same issue as mentioned in my first comment, so I don't think it's really an option.

[juliand665]

Fair enough—I'm probably working off a less precise understanding of this system than you :)