Smooth volume transition #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side note, this might be the favorite feature I've ever made for this mod :) Makes it feel very polished. |
LostLuma
force-pushed
the
smooth-volume-transition
branch
from
ae4a75b to
6e81217
Compare
|
Will this feature be backported to 1.20.1/4 or no? |
|
That's the plan, yeah. Generally I try to backport all the way to 1.16.5 (unless a feature doesn't work for older Minecraft versions). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a smooth transition when changing between different volume multipliers.
By default this feature will transition volume from 100% to 0% within 2 seconds, and reverse within 1 second.
The speed for both upward and downward transition can be adjusted in the config to be a bit shorter or longer.
This was originally added to Dynamic FPS Reforged by @N4TH4NOT before we had sound category support or a Forge version.
Since their idea still influenced this a lot (otherwise I wouldn't have had this idea in the first place) I've added them to our credits.