Add Forge and NeoForge support #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be fixed in a more proper way later when I have time to.
Arch Loom currently fails to remap targets of the `@Shadow` annotation from Mixin.
|
Well I'm going to merge this as-is without waiting for anyone to look over it right now because I have some other unrelated bug fixes I'd like to do, and I'd like to get all of this stuff done today / this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Forge and NeoForge using Architectury Loom.
Currently their NeoForge support is in beta, and it is either somewhat broken or I have messed something up, as using the Mixin
@Shadowand@Overwriteannotations in a common module mixin will fail to remap properly when building the NeoForge module, and subsequently crash Minecraft.I have worked around this by replacing all uses of the
@Shadowannotation with access wideners, and replacing the only use of an@Overwritewith two individual injections (see commit). I plan to revert this in the future whenever it is possible.There's still a lot that can be improved about this at a later date, however I'd like to focus on something else for now and get this out the door. As it stands this works on all four platforms on Minecraft 1.20.0 to 1.20.4 (and I'll backport outside of the PR).