Shard awareness #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jul-stas
force-pushed
the
shard-awareness
branch
from
baa5e98 to
c41faa4
Compare
jul-stas
force-pushed
the
shard-awareness
branch
3 times, most recently
from
7d7c09a to
1f98865
Compare
This required supplying std::optional from a 3rd party implementation (by Andrzej Krzemienski). The selection of `optional` is done on the basis of C++ standard version, e.g.: cmake -DCASS_CPP_STANDARD=17 .. will use std::optional, while `-DCASS_CPP_STANDARD=11` will fall back to the 3rd party impl.
At this point metrics indicate that cross-shard ops are reduced, but the implementation is still raw. The reasons: When connection-to-the-right-shard is being searched among per-host connections, it is done by linear search. Connecting logic does not attempt to reconnect until all shards are hit. Topology change events are not accounted for.
jul-stas
force-pushed
the
shard-awareness
branch
from
1f98865 to
0178646
Compare
jul-stas
force-pushed
the
shard-awareness
branch
from
0178646 to
7146bc6
Compare
The reconnection is being scheduled until we reach the desired number of connections per shard. The other change is that instead of picking the 'least busy' connection from the host's pool, we pick the least busy one from the "shards pool".
jul-stas
force-pushed
the
shard-awareness
branch
from
7146bc6 to
ddec859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design is based on shard-awareness in java driver.