_denormalize_destroy_to_* callback fixed to trigger before the destroy op #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
THanks @pranav-g10, this looks great. Is it possible to add a test case for when the |
The to_alize destroy callbacks used to be a after_destroy callback which failed when relations specified a :nullify dependency - since mongoid would nullify all relations before the destroy and the after_destroy callback would find no children after the destroy op to sync. Changed the callback to be triggered before the destroy op, except in the case of a :restrict dependency where a before_destroy callback would pre-maturely sync the child objects even though the destroy op may never happen
pranav-g10
force-pushed
the
to_alize_destroy_cb
branch
from
3efb5e3 to
76e62fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #42