Upgrade play-mailer and use new play-mailer repo #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscha
added a commit
that referenced
this pull request
May 24, 2015
Upgrade play-mailer and use new play-mailer repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Play team moved the repo of it's mailer plugin.
Also a new version was released just a few hours ago.
This PR is just a quick refactoring to match the changed API (but does not yet update the samples). Probably the code could be refactored in a better way...
@joscha The new version now introduces an Email class. Wouldn't this make "your" class
com.feth.play.module.mail.Mailer.Mailobsolete?Plus there is also talk about implementing a
sendAsyncmethod, maybe in future this can be reused in your library.