[MRG] TST: add view window tests #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakecaldwell
force-pushed
the
issue_243
branch
from
f0d35fc to
cdda0aa
Compare
blakecaldwell
force-pushed
the
issue_243
branch
from
20cb8a5 to
e1fdae4
Compare
blakecaldwell
force-pushed
the
issue_243
branch
from
e1fdae4 to
e096020
Compare
blakecaldwell
force-pushed
the
issue_243
branch
from
1280a9a to
4bd0016
Compare
blakecaldwell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like we initialize the main HNN GUI window (hnn_qt5.py) during testing and then have it gracefully exit with
TRAVIS_TESTING=1, we can do the same with windows showing dipole, raster, spectrogram, and PSD plots. This PR adds tests for each of those windows that simply initializes the window and then exits. If there no uncaught exceptions, then the process that started the window will exit successfully and the test will pass.Tests can be improved further in #232 (a test for somatic voltages should be added). Having this in place will allow for catching errors potentially exposed by #236.
Resolves #243