Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update to vc-data-model v1.0 #4

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: update to vc-data-model v1.0 #4

wants to merge 1 commit into from

Conversation

PeterTheOne
Copy link

issued -> issuanceDate
claim -> credentialSubject

I'm not sure if other changes are also needed, maybe also something related to signature/proof?

see: jolocom/jolocom-lib#393

chunningham
chunningham approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@chunningham chunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, will merge after confirming this is all that is needed

@mnzaki mnzaki changed the base branch from master to develop March 5, 2021 10:34
@mnzaki
Copy link
Contributor

mnzaki commented Mar 5, 2021

Hello @PeterTheOne
I'm picking this up again, it will need some updates to the library and SDK and possibly either compatibility support code or otherwise we'd have to do a major version bump.
Thank you for this PR, I'd be happy to merge it if you don't mind signing off our CLA (I just updated this info in CONTRIBUTING.md)

@PeterTheOne
Copy link
Author

@mnzaki I can sign my commits but how do I sign the CLA?

@PeterTheOne
fix: update to vc-data-model v1.0
3ba70c6 
issued -> issuanceDate
claim -> credentialSubject

jolocom/jolocom-lib#393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunningham chunningham chunningham approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterTheOne @mnzaki @chunningham