Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Django 5.0 #506

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Test on Django 5.0 #506

merged 1 commit into from
Oct 28, 2023

Conversation

adamchainz
Copy link
Contributor

New Django version incoming!

I copied from #456 for this update. Running the tests locally, I found no failures or new warnings, so it appears that django-environ is compatible.

I would recommend dropping old Django versions that are no longer supported. Would you be interested in a follow-up PR doing so?

@coveralls
Copy link

coveralls commented Oct 27, 2023

Coverage Status

coverage: 92.612% (+0.3%) from 92.268% when pulling 79b30c7 on adamchainz:django_5.0 into e3e7fc9 on joke2k:develop.

@sergeyklay sergeyklay merged commit a1113e4 into joke2k:develop Oct 28, 2023
26 checks passed
@sergeyklay
Copy link
Collaborator

Thank you!

@adamchainz adamchainz deleted the django_5.0 branch October 28, 2023 21:37
@adamchainz
Copy link
Contributor Author

Thanks for merging. Can you respond to my question about dropping old versions?

@sergeyklay
Copy link
Collaborator

I would recommend dropping old Django versions that are no longer supported. Would you be interested in a follow-up PR doing so?

We strive to support all Django versions up to the latest and do not plan on dropping them without a compelling reason. At this point, I see no reason to deprive users who, for various circumstances, are using older versions of Django from receiving library updates. Dropping support for older versions would only be considered if there is a substantial rationale for doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants