Add support for direct responses #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all responses are delayed using thee response URL for slash commands, this allows for direct responses to the original request.
callback() is triggered automatically if no error is passed when the node event loop is empty. No need for any fancy handling.
Sometimes with lambda you're hitting a still running instance of the function so the binding happens on each call causing the callback to be prepended to the args multiple times.
The way you have to send URL encoded complex messages to slack means we need some custom serialisation. Values like the attachments array will be stripped by `qs.stringify()` so we need to `JSON.stringify()` those values and then URL encode them. 🤦♂️
AWS keeps the same function alive and in memory but the handler is called each time. This updates the callback and exposes it during handler execution.
|
@johnagan this is pretty well tested now in my current use cases, let me know if you have a better solution in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes in the case of slash commands it's useful to have the users command displayed too - it helps to educate / show other users how to use a command they may not have seen before.
It can also add context to a response rather than the response having to indicate what just happened when it's visible to all users.
Without a direct response
What I see:
What everyone else sees:
With a direct response
Everyone sees: