Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undeprecate ConsolePrompt methods et al #1148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Undeprecate ConsolePrompt methods et al #1148

wants to merge 1 commit into from

Conversation

quintesse
Copy link
Contributor

@quintesse quintesse commented Jan 8, 2025 •
edited
Loading

Implemented:

  • open()/close() methods for ConsolePrompt
  • calling open()/close() in prompt() methods that return Maps
  • removed @Deprecated annotations
  • removed new and unused (non Map returning) prompt() method
  • made new (non Map returning) prompt() method protected
  • fixed examples
  • made sure all ConsolePrompt fields are protected

Fixes #1141

@quintesse quintesse changed the title Undeprecate ConsolePrompt methods Undeprecate ConsolePrompt methods et all Jan 8, 2025
@quintesse quintesse changed the title Undeprecate ConsolePrompt methods et all Undeprecate ConsolePrompt methods et al Jan 8, 2025
@quintesse
Copy link
Contributor Author

Hi @mattirn , created this PR as a possible way to implement your suggestions from #1141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review ConsolePrompt's method visibilities
1 participant
@quintesse