Skip to content

Commit

Permalink
Minor typo fixes in GC docs (#204)
Browse files Browse the repository at this point in the history
  • Loading branch information
Johennes authored Jan 8, 2025
1 parent 8cc0509 commit 32a455c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/src/idioms/gc.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ The simplest route for this would be to use a [`FinalizationRegistry`](https://d

Unfortunately, [this is not yet supported by hermes](https://github.com/facebook/hermes/issues/604). ([New issue](https://github.com/facebook/hermes/issues/1440))

Instead, for every Javascript object constructor called, we call create a `DestructibleObject` in C++, that is represented in Javascript but has a [C++ destructor](https://isocpp.org/wiki/faq/dtors).
Instead, for every Javascript object constructor called, we create a `DestructibleObject` in C++, that is represented in Javascript but has a [C++ destructor](https://isocpp.org/wiki/faq/dtors).

[At the end of this \[C++\] object's lifetime](https://en.cppreference.com/w/cpp/language/destructor), the destructor is called.

Expand Down Expand Up @@ -59,4 +59,4 @@ const result = new MyObject().uniffiUse((obj) => {

### Future work

If there is any movement on[ hermes' `FinalizationRegistry` support](https://github.com/facebook/hermes/issues/1440)) we may well consider moving to this method.
If there is any movement on [hermes' `FinalizationRegistry` support](https://github.com/facebook/hermes/issues/1440), we may well consider moving to this method.

0 comments on commit 32a455c

Please sign in to comment.