This repository has been archived by the owner on Mar 21, 2021. It is now read-only.
Add service query method for Vue front-end filtering calls #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for your PR ! then, can you update your git config too ? as your config is related to JHipster Bot |
pascalgrimaud
suggested changes
Mar 15, 2020
| @@ -0,0 +1,13 @@ | |||
| export default function buildQueryParams(queryParams) { | |||
There was a problem hiding this comment.
it would be cool to add test for this file
| @@ -165,6 +165,7 @@ const vueFiles = { | |||
| 'core/ribbon/ribbon.vue', | |||
| 'core/ribbon/ribbon.component.ts', | |||
| 'shared/date/filters.ts', | |||
| 'shared/query/params.ts', | |||
There was a problem hiding this comment.
following the other comment, needs to add params.spec.ts too
|
Kevin Whittington seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the below checklist is followed for Pull Requests.
All continuous integration tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed