test: improve test coverage

[TJM]

Add a few error state tests to improve test coverage on config/rotate

• path_config_rotate.go
  • master: 77.1% (overall 62.4%)
  • this branch: 88.6% (overall 65%)

[TJM]

We have all the "positive" test cases covered, but I am not sure how to create some of the errors. If you have ideas, let me know. I am going to tackle /config/admin next.

[TJM]

• path_config.go
  • master: 68.1% (62.4% overall)
  • this branch: 91.2% (68.2% overall)

[TJM]

Learned something...

We don't need this case statement to check for bool, because no matter what we submit, it comes out as a string? although this feels like a bug to me :)

[alexhung]

Learned something...

We don't need this case statement to check for bool, because no matter what we submit, it comes out as a string? although this feels like a bug to me :)

Most likely because the attribute is defined as TypeString (https://github.com/jfrog/artifactory-secrets-plugin/blob/master/path_config.go#L33) 😄

Instead we should use TypeBool.

[alexhung]

LGTM. Just the commented out line of code.

[TJM]

Learned something...
We don't need this case statement to check for bool, because no matter what we submit, it comes out as a string? although this feels like a bug to me :)

Most likely because the attribute is defined as TypeString (https://github.com/jfrog/artifactory-secrets-plugin/blob/master/path_config.go#L33) 😄

Instead we should use TypeBool.

Created a new issue for this.