Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTRENG-6513 - Upgrade FluentD sidecar to version 4.13 #60

Merged
merged 1 commit into from
Nov 7, 2024
Merged

PTRENG-6513 - Upgrade FluentD sidecar to version 4.13 #60

merged 1 commit into from
Nov 7, 2024

Conversation

benharosh
Copy link
Collaborator

  • Upgrade FluentD sidecar to version 4.13 to include changes made in jfrog_siem and jfrog_metrics FluentD plugins

alexhung
alexhung reviewed Nov 7, 2024
View reviewed changes
README.md Outdated
@@ -265,7 +263,7 @@ export MASTER_KEY=$(openssl rand -hex 32)
--set artifactory.license.dataKey=artifactory.cluster.license \
--set artifactory.metrics.enabled=true \
-n $INST_NAMESPACE
```
```s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this s intentional?

Copy link
Collaborator Author

@benharosh benharosh Nov 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The customer can provide their own license manually. I had issues with customers not providing the k8s license secret, and it made helm deployment to fail. Providing a license can shorten the "on-boarding" of a new platform - but most of customers will not use it anyway (in a big deployment - they will be hand held by our support team). It can be useful for test environments

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh wait I missed the s - fixing it now

@benharosh benharosh requested a review from alexhung November 7, 2024 21:58
@benharosh benharosh merged commit 2f28565 into master Nov 7, 2024
@benharosh benharosh deleted the PTRENG-6513 branch November 7, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexhung alexhung alexhung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benharosh @alexhung