Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix omitempty issue on 'jf how' request #2722

Merged
merged 15 commits into from
Oct 21, 2024
Merged

Fix omitempty issue on 'jf how' request #2722

merged 15 commits into from
Oct 21, 2024

Conversation

sverdlov93
Copy link
Contributor

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@sverdlov93
Improve repositores code
7e2db95 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into npm-login
b3b2401 
# Conflicts:
#	go.sum
@sverdlov93
Improve repositores code
80a94c7 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Improve repositores code
9c7a467 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Improve repositores code
2d7a90c 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Improve repositores code
faa0521 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Improve repositores code
ee1c68d 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 changed the base branch from v2 to dev October 13, 2024 11:08
@sverdlov93
Improve repositores code
eb35483 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Improve repositores code
f3a4155 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Oct 13, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 13, 2024
@sverdlov93 sverdlov93 requested a review from yahavi October 13, 2024 12:11
@sverdlov93
Improve repositores code
fc3baac 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Improve repositores code
2af5a7b 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Improve repositores code
51d4f2d 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 changed the title Update dependencies Fix omitempty issue on 'jf how' request Oct 13, 2024
@sverdlov93
Improve repositores code
581e2ec 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 requested a review from eyalbe4 October 15, 2024 10:56
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Oct 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 21, 2024
@sverdlov93 sverdlov93 merged commit c036653 into jfrog:dev Oct 21, 2024
54 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi left review comments

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sverdlov93 @eyalbe4 @yahavi