Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for maven and gradle build timestamp #2296

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Add tests for maven and gradle build timestamp #2296

merged 5 commits into from
Nov 7, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Nov 6, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

depends on jfrog/build-info-go#209

@attiasas attiasas added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Nov 6, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 6, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 6, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 6, 2023
@attiasas attiasas requested review from yahavi and eyalbe4 November 6, 2023 09:27
@attiasas attiasas changed the title Add tests for maven build timestamp Add tests for maven and gradle build timestamp Nov 6, 2023
yahavi
yahavi requested changes Nov 7, 2023
View reviewed changes
gradle_test.go Outdated Show resolved Hide resolved
maven_test.go Outdated Show resolved Hide resolved
@eyalbe4 eyalbe4 removed their request for review November 7, 2023 09:49
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2023
@attiasas attiasas merged commit d719d6b into jfrog:dev Nov 7, 2023
56 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @yahavi