Move to env

jfrog · Jan 9, 2025 · e740f23 · e740f23
1 parent ff288fe
commit e740f23
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/Jenkinsfile b/Jenkinsfile
@@ -536,8 +536,11 @@ def dockerLogin(){
 def triggerDarwinBinariesSigningWorkflow() {
     withCredentials([string(credentialsId: 'eyalde-github-access-token', variable: "GITHUB_ACCESS_TOKEN")]) {
         stage("Sign MacOS binaries") {
-            sh('chmod +x $repo/build/apple_release/scripts/trigger-sign-mac-OS-workflow.sh')
-            sh('$repo/build/apple_release/scripts/trigger-sign-mac-OS-workflow.sh $cliExecutableName $releaseVersion $GITHUB_ACCESS_TOKEN')
+            sh 'chmod +x $repo/build/apple_release/scripts/trigger-sign-mac-OS-workflow.sh'
+            sh """
+                    export GITHUB_ACCESS_TOKEN=${GITHUB_ACCESS_TOKEN}
+                    $repo/build/apple_release/scripts/trigger-sign-mac-OS-workflow.sh $cliExecutableName $releaseVersion $goarch
+            """
         }
     }
 }
@@ -550,7 +553,10 @@ def triggerDarwinBinariesSigningWorkflow() {
  */
 def downloadDarwinSignedBinaries(goarch) {
     withCredentials([string(credentialsId: 'eyalde-github-access-token', variable: "GITHUB_ACCESS_TOKEN")]) {
-        sh ('chmod +x $repo/build/apple_release/scripts/download-signed-mac-OS-binaries.sh')
-        sh ('$repo/build/apple_release/scripts/download-signed-mac-OS-binaries.sh $cliExecutableName $releaseVersion $goarch $GITHUB_ACCESS_TOKEN')
+        sh 'chmod +x $repo/build/apple_release/scripts/download-signed-mac-OS-binaries.sh'
+        sh """
+            export GITHUB_ACCESS_TOKEN=${GITHUB_ACCESS_TOKEN}
+            $repo/build/apple_release/scripts/download-signed-mac-OS-binaries.sh $cliExecutableName $releaseVersion $goarch
+        """
     }
 }
diff --git a/build/apple_release/scripts/download-signed-mac-OS-binaries.sh b/build/apple_release/scripts/download-signed-mac-OS-binaries.sh
@@ -10,8 +10,7 @@ releaseVersion=$2
 # The architecture of the macOS binary to be downloaded - amd64 or arm64
 goarch=$3
 
-# GitHub Access Token for authentication
-GITHUB_ACCESS_TOKEN=$3
+# GitHub Access Token for authentication from ENV
 
 # Function to retrieve the specific artifact URL with retries
 get_specific_artifact_url_with_retries() {

diff --git a/build/apple_release/scripts/trigger-sign-mac-OS-workflow.sh b/build/apple_release/scripts/trigger-sign-mac-OS-workflow.sh
@@ -9,8 +9,8 @@ cliExecutableName=$1
 # The version of the release being processed
 releaseVersion=$2
 
-# GitHub Access Token for authentication
-GITHUB_ACCESS_TOKEN=$3
+# GitHub Access Token for authentication from ENV
+
 
 
 # Trigger