-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build-add-git): severe performance issue #982
Closed
Closed
+5
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve UI for scan command (jfrog#706) * Upgrade go version in go.mod to 1.20 (jfrog#732) * Fix lint issues found (jfrog#733) * Config transfer - ensure target not older than source (jfrog#721) * Update tests environment - nuget and dotnet to version 6 (jfrog#734) * Flatten audit graph (jfrog#736) * Use gradle-dep-tree with Audit (jfrog#719) --------- Co-authored-by: Sara Omari <[email protected]> Co-authored-by: Eyal Ben Moshe <[email protected]> Co-authored-by: Michael Sverdlov <[email protected]> Co-authored-by: Yahav Itzhak <[email protected]>
# Conflicts: # .github/workflows/analysis.yml # go.mod # go.sum # xray/audit/java/gradle.go # xray/commands/audit/generic/auditmanager.go
on our artifactory instance, the performance of the build-add-git command increased from ~4m to <1s, even for repositories with 20k commits the functionality `getLatestVcsRevision` from (possible) previously uploaded build infos was removed for the following reasons: - the aql query was broken anyway (result was always empty) - the broken aql query lead to a call to a GET call to /api/build without further args, which seems to retrieve all builds and caused severe performance issues - other than for performance reasons, I see no significant reason to query the vcs revision history of past builds -> And since almost any api call will always be slower than just scanning the whole git history of a repo, I don't see the reason for this functionality to be there
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
this seems having been fixed independently in meantime -> successfully tested it with jf cli version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our artifactory instance, the performance of the build-add-git command increased from ~4m to <1s, even for repositories with 20k commits
the functionality
getLatestVcsRevision
from (possible) previously uploaded build infos was removed for the following reasons:the aql query was broken anyway (result was always empty)
the broken aql query lead to a call to a GET call to /api/build without further args, which seems to retrieve all builds and caused severe performance issues
other than for performance reasons, I see no significant reason to query the vcs revision history of past builds -> And since almost any api call will always be slower than just scanning the whole git history of a repo, I don't see the reason for this functionality to be there
All tests passed. If this feature is not already covered by the tests, I added new tests.
All static analysis checks passed.
This pull request is on the dev branch.
I used gofmt for formatting the code before submitting the pull request.