Docker scan - map vulnerabilities to Dockerfile commands #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factor_print_table
…factor_print_table
…prove_docker_scan
…factor_print_table
sverdlov93
reviewed
Oct 5, 2023
sverdlov93
reviewed
Oct 5, 2023
sverdlov93
reviewed
Oct 5, 2023
| }() | ||
| // Preform Binary scan | ||
| extendedScanResults, cleanup, scanErrors, err := scanCmd.binaryScan() | ||
| defer cleanup() |
sverdlov93
reviewed
Oct 5, 2023
sverdlov93
reviewed
Oct 5, 2023
sverdlov93
reviewed
Oct 5, 2023
EyalDelarea
commented
Oct 5, 2023
| if len(rows[i].FixedVersions) != len(rows[j].FixedVersions) { | ||
| return len(rows[i].FixedVersions) > len(rows[j].FixedVersions) | ||
| } | ||
| return rows[i].ImpactedDependencyName > rows[j].ImpactedDependencyName |
There was a problem hiding this comment.
@sverdlov93 this will effect the audit as well
added sort by package name after fixed version suggestion
|
@sverdlov93 notice now the sort will show same packages near each other, maybe we should add other sort inside package names by so it will look better. |
yahavi
added a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enrich
jf docker scanresults with the origin command to the vulnerability found. And customize the docker scan table with more suitable parameters.Before:
After:
Depends on: jfrog/jfrog-client-go#817