Transfer - Fix delayed artifacts mechanism #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahavi
force-pushed
the
fix-delayed-artifacts
branch
from
b0c34bb to
7192e3a
Compare
yahavi
force-pushed
the
fix-delayed-artifacts
branch
from
7192e3a to
bc70c15
Compare
4 tasks
RobiNino
requested changes
Sep 13, 2023
yahavi
force-pushed
the
fix-delayed-artifacts
branch
from
222b925 to
b24d1cb
Compare
attiasas
reviewed
Sep 14, 2023
| log.Info(fmt.Sprintf("Uploading %d delayed artifacts...", len(allDelayedArtifacts))) | ||
| allDelayedArtifacts = sortDelayedArtifacts(&allDelayedArtifacts, delayHelper) | ||
| // Use an empty delayUploadHelper to prevent further delays of these files. | ||
| shouldStop, err := uploadByChunks(allDelayedArtifacts, uploadChunkChan, base, delayUploadHelper{}, errorsChannelMng, pcWrapper) |
There was a problem hiding this comment.
If a delayed artifact fails here, for example, 'conanfile.py', then the following file at the ordered delayed list is for example 'conaninfo.txt' and no issue at upload, won't it be a problem later when we try to upload It again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests PR: jfrog/jfrog-cli#2204
Enhance and optimize the following elements:
*.pom.