Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer files - Remove redundant lock in snapshot #956

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Transfer files - Remove redundant lock in snapshot #956

merged 2 commits into from
Sep 14, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Sep 13, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Before: lock saveRepoSnapshotMutex and saveStateMutex.
After: lock only saveRepoSnapshotMutex

@yahavi yahavi added the improvement Automatically generated release notes label Sep 13, 2023
@yahavi yahavi requested review from eyalbe4 and RobiNino September 13, 2023 10:46
@yahavi yahavi self-assigned this Sep 13, 2023
@yahavi yahavi marked this pull request as ready for review September 13, 2023 16:10
@yahavi yahavi merged commit e0c711f into jfrog:dev Sep 14, 2023
1 check failed
@yahavi yahavi deleted the redundant-lock branch September 14, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobiNino RobiNino RobiNino approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @RobiNino