Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Resultwriter #929

Merged
merged 22 commits into from
Sep 26, 2023
Merged

Refactor Resultwriter #929

merged 22 commits into from
Sep 26, 2023

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Sep 4, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Refactor print results and change it to a struct
This is pre work needed for docker scan command results change.

@EyalDelarea EyalDelarea added the ignore for release Automatically generated release notes label Sep 4, 2023
@EyalDelarea EyalDelarea changed the title Refactor print table Refactor Resultwriter Sep 4, 2023
@EyalDelarea EyalDelarea marked this pull request as ready for review September 4, 2023 12:52
@EyalDelarea EyalDelarea mentioned this pull request Sep 20, 2023
Closed
4 tasks
attiasas
attiasas suggested changes Sep 26, 2023
View reviewed changes
xray/utils/resultwriter.go Outdated Show resolved Hide resolved
xray/commands/audit/audit.go Outdated Show resolved Hide resolved
xray/utils/resultwriter.go Outdated Show resolved Hide resolved
@EyalDelarea EyalDelarea temporarily deployed to frogbot September 26, 2023 11:52 — with GitHub Actions Inactive
@EyalDelarea EyalDelarea temporarily deployed to frogbot September 26, 2023 12:23 — with GitHub Actions Inactive
@EyalDelarea EyalDelarea temporarily deployed to frogbot September 26, 2023 12:34 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

@EyalDelarea EyalDelarea merged commit 7a180ec into jfrog:dev Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas requested changes

@asafgabai asafgabai Awaiting requested review from asafgabai

@sverdlov93 sverdlov93 Awaiting requested review from sverdlov93

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EyalDelarea @attiasas